[GitHub] thrift pull request: THRIFT-2668 TestSuite: detailed result on pas...

2014-08-20 Thread cdwijayarathna
Github user cdwijayarathna commented on the pull request: https://github.com/apache/thrift/pull/194#issuecomment-52760264 @bufferoverflow committed suggested changes in java, cpp, py. Since python uses unittest framework, using exit(ret), stopped printing failure details of failed

[GitHub] thrift pull request: THRIFT-2655 CPP tests should not use relative...

2014-08-20 Thread cdwijayarathna
GitHub user cdwijayarathna opened a pull request: https://github.com/apache/thrift/pull/198 THRIFT-2655 CPP tests should not use relative path when accessing ssh related files You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] thrift pull request: THRIFT-2655 CPP tests should not use relative...

2014-08-20 Thread cdwijayarathna
Github user cdwijayarathna closed the pull request at: https://github.com/apache/thrift/pull/198 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request: THRIFT-847 Test Framework harmonization acros...

2014-08-18 Thread cdwijayarathna
Github user cdwijayarathna closed the pull request at: https://github.com/apache/thrift/pull/193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request: THRIFT-2668 TestSuite: detailed result on pas...

2014-08-18 Thread cdwijayarathna
GitHub user cdwijayarathna opened a pull request: https://github.com/apache/thrift/pull/194 THRIFT-2668 TestSuite: detailed result on passed tests by feature THRIFT-2668 TestSuite: detailed result on passed tests by feature added for py, java and cpp You can merge this pull

[GitHub] thrift pull request: THRIFT-2668 TestSuite: detailed result on pas...

2014-08-18 Thread cdwijayarathna
Github user cdwijayarathna commented on a diff in the pull request: https://github.com/apache/thrift/pull/194#discussion_r16376522 --- Diff: lib/java/test/org/apache/thrift/test/TestClient.java --- @@ -642,7 +684,28 @@ public static void main(String [] args

[GitHub] thrift pull request: THRIFT-2652 THRIFT_TEST_PORT variable via to ...

2014-08-17 Thread cdwijayarathna
Github user cdwijayarathna closed the pull request at: https://github.com/apache/thrift/pull/192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request: THRIFT-2652 THRIFT_TEST_PORT variable via to ...

2014-08-16 Thread cdwijayarathna
GitHub user cdwijayarathna opened a pull request: https://github.com/apache/thrift/pull/192 THRIFT-2652 THRIFT_TEST_PORT variable via to run tests in parallel python test.py --port=9091 ./test.sh 9090 You can merge this pull request into a Git repository by running: $ git

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2014-08-16 Thread cdwijayarathna
Github user cdwijayarathna closed the pull request at: https://github.com/apache/thrift/pull/191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request: THRIFT-847 Test Framework harmonization acros...

2014-08-16 Thread cdwijayarathna
Github user cdwijayarathna commented on a diff in the pull request: https://github.com/apache/thrift/pull/190#discussion_r16324539 --- Diff: test/hs/TestClient.hs --- @@ -197,24 +198,24 @@ main = do Binary - runClient $ BinaryProtocol handle

[GitHub] thrift pull request: THRIFT-847 Test Framework harmonization acros...

2014-08-16 Thread cdwijayarathna
Github user cdwijayarathna closed the pull request at: https://github.com/apache/thrift/pull/190 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request: THRIFT-847 Test Framework harmonization acros...

2014-08-16 Thread cdwijayarathna
GitHub user cdwijayarathna opened a pull request: https://github.com/apache/thrift/pull/193 THRIFT-847 Test Framework harmonization across all languages Edits suggested by @zilberstein added to Haskell tests. You can merge this pull request into a Git repository by running

[GitHub] thrift pull request: THRIFT-847 Test Framework harmonization acros...

2014-08-16 Thread cdwijayarathna
Github user cdwijayarathna commented on a diff in the pull request: https://github.com/apache/thrift/pull/190#discussion_r16325997 --- Diff: test/hs/TestClient.hs --- @@ -197,24 +198,24 @@ main = do Binary - runClient $ BinaryProtocol handle

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2014-08-15 Thread cdwijayarathna
GitHub user cdwijayarathna opened a pull request: https://github.com/apache/thrift/pull/191 THRIFT-2578 Moving 'make cross' from test.sh to test.py --server attribute and --client attribute added. Uses comma separated server and client inputs (eg: --server=cpp,py , --client=hs

[GitHub] thrift pull request: THRIFT-847 Test Framework harmonization acros...

2014-08-15 Thread cdwijayarathna
Github user cdwijayarathna commented on the pull request: https://github.com/apache/thrift/pull/190#issuecomment-52356290 @bufferoverflow Added changes suggested by @zilberstein in https://github.com/cdwijayarathna/thrift/commit/33fe8f6da989181060d4c502a27426b7d57ff046 , should I

[GitHub] thrift pull request: THRIFT-847 Test Framework harmonization acros...

2014-08-15 Thread cdwijayarathna
Github user cdwijayarathna commented on the pull request: https://github.com/apache/thrift/pull/190#issuecomment-52358462 @bufferoverflow Added suggested changes and committed. Is there anything else I need to do for this? --- If your project is set up for it, you can reply

[GitHub] thrift pull request: THRIFT-847 Test Framework harmonization acros...

2014-08-15 Thread cdwijayarathna
Github user cdwijayarathna commented on the pull request: https://github.com/apache/thrift/pull/190#issuecomment-52359274 I removed trailing white spaces in files I edited, do I need to undo them? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] thrift pull request: THRIFT-847 Test Framework harmonization acros...

2014-08-15 Thread cdwijayarathna
Github user cdwijayarathna commented on a diff in the pull request: https://github.com/apache/thrift/pull/190#discussion_r16316696 --- Diff: test/hs/TestClient.hs --- @@ -197,24 +198,24 @@ main = do Binary - runClient $ BinaryProtocol handle

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2014-08-11 Thread cdwijayarathna
Github user cdwijayarathna closed the pull request at: https://github.com/apache/thrift/pull/180 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request: THRIFT-2655 CPP tests should not use relative...

2014-08-11 Thread cdwijayarathna
Github user cdwijayarathna closed the pull request at: https://github.com/apache/thrift/pull/178 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request: THRIFT-2655 CPP tests should not use relative...

2014-08-09 Thread cdwijayarathna
GitHub user cdwijayarathna opened a pull request: https://github.com/apache/thrift/pull/178 THRIFT-2655 CPP tests should not use relative path when accessing ssh related files Need a doc update for http://thrift.apache.org/docs/install/debian . You can merge this pull request

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2014-08-09 Thread cdwijayarathna
Github user cdwijayarathna commented on a diff in the pull request: https://github.com/apache/thrift/pull/173#discussion_r16026320 --- Diff: test/test.py --- @@ -90,14 +92,18 @@ def runServiceTest(test_name, server_lib, server_executable, server_extra_args

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2014-08-09 Thread cdwijayarathna
GitHub user cdwijayarathna opened a pull request: https://github.com/apache/thrift/pull/180 THRIFT-2578 Moving 'make cross' from test.sh to test.py You can merge this pull request into a Git repository by running: $ git pull https://github.com/cdwijayarathna/thrift THRIFT

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2014-08-08 Thread cdwijayarathna
Github user cdwijayarathna closed the pull request at: https://github.com/apache/thrift/pull/173 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2014-08-07 Thread cdwijayarathna
Github user cdwijayarathna commented on a diff in the pull request: https://github.com/apache/thrift/pull/173#discussion_r15930173 --- Diff: test/test.py --- @@ -90,14 +92,18 @@ def runServiceTest(test_name, server_lib, server_executable, server_extra_args

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2014-08-06 Thread cdwijayarathna
Github user cdwijayarathna commented on a diff in the pull request: https://github.com/apache/thrift/pull/173#discussion_r15918465 --- Diff: test/tests.json --- @@ -4,7 +4,7 @@ description: Python TestClient, lib: py, executable

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2014-08-06 Thread cdwijayarathna
Github user cdwijayarathna commented on a diff in the pull request: https://github.com/apache/thrift/pull/173#discussion_r15918500 --- Diff: test/test.py --- @@ -90,14 +92,18 @@ def runServiceTest(test_name, server_lib, server_executable, server_extra_args

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2014-08-05 Thread cdwijayarathna
GitHub user cdwijayarathna opened a pull request: https://github.com/apache/thrift/pull/173 THRIFT-2578 Moving 'make cross' from test.sh to test.py Added exit feature to tests.json. Py server, py client and cpp server exit is hard while others are soft. py server - py

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2014-08-02 Thread cdwijayarathna
Github user cdwijayarathna closed the pull request at: https://github.com/apache/thrift/pull/170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request: Thrift 2578

2014-08-01 Thread cdwijayarathna
GitHub user cdwijayarathna opened a pull request: https://github.com/apache/thrift/pull/170 Thrift 2578 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cdwijayarathna/thrift THRIFT-2578 Alternatively you can review and apply

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2014-07-30 Thread cdwijayarathna
Github user cdwijayarathna closed the pull request at: https://github.com/apache/thrift/pull/167 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2014-07-30 Thread cdwijayarathna
GitHub user cdwijayarathna opened a pull request: https://github.com/apache/thrift/pull/168 THRIFT-2578 Moving 'make cross' from test.sh to test.py Commit 55e6482 edited test reporting You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] thrift pull request: Thrift 2578

2014-07-28 Thread cdwijayarathna
GitHub user cdwijayarathna opened a pull request: https://github.com/apache/thrift/pull/167 Thrift 2578 Added platform to tests.json mentioned by @bufferoverflow 81da564 need to be committed You can merge this pull request into a Git repository by running: $ git pull

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2014-07-26 Thread cdwijayarathna
GitHub user cdwijayarathna opened a pull request: https://github.com/apache/thrift/pull/166 THRIFT-2578 Moving 'make cross' from test.sh to test.py Allows test.py to run without interruption, even if some test clients and servers are not runnable. Eg -: cpp/TestServer.o

[GitHub] thrift pull request: Thrift 2578

2014-07-09 Thread cdwijayarathna
Github user cdwijayarathna closed the pull request at: https://github.com/apache/thrift/pull/152 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request: THRIFT-2578 Moving 'make cross' from test.sh ...

2014-07-09 Thread cdwijayarathna
Github user cdwijayarathna closed the pull request at: https://github.com/apache/thrift/pull/153 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request: Thrift 2578

2014-07-05 Thread cdwijayarathna
GitHub user cdwijayarathna opened a pull request: https://github.com/apache/thrift/pull/152 Thrift 2578 Moving 'make cross' from test.sh to test.py, You can merge this pull request into a Git repository by running: $ git pull https://github.com/cdwijayarathna/thrift THRIFT