[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C

2017-04-02 Thread clindsay
Github user clindsay commented on the issue: https://github.com/apache/thrift/pull/1031 I've been using it in a project since last summer, communicating between a python process and a Swift/Objective-C process. The project has been in beta with a few hundred users, and no reports

[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C

2017-03-31 Thread clindsay
Github user clindsay commented on the issue: https://github.com/apache/thrift/pull/1031 Hey @jeking3, sorry for going silent there. I've had a lot of other things on my plate, and haven't gotten to this yet, but I still intend to add this support when I have a chance! --- If your

[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C

2017-02-16 Thread clindsay
Github user clindsay commented on the issue: https://github.com/apache/thrift/pull/1031 Thanks @jeking3. Sorry for the slow response, a bit busy these days! Just to clarify, as far as I can tell there isn't a cocoa test client today. Is this correct? So, in order to add

[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C

2017-02-05 Thread clindsay
Github user clindsay commented on the issue: https://github.com/apache/thrift/pull/1031 No problem. Just rebased on master. I will work on adding to the "make cross" test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] thrift issue #1031: THRIFT-3859: Add support for Unix Domain Sockets to TSoc...

2016-06-21 Thread clindsay
Github user clindsay commented on the issue: https://github.com/apache/thrift/pull/1031 The diff generated by GitHub makes the change look a little bigger than it actually is. In TSocketServer.m, the `initWithSocket` method is effectively the same as the old `initWithPort` method

[GitHub] thrift issue #1031: THRIFT-3859: Add support for Unix Domain Sockets to TSoc...

2016-06-21 Thread clindsay
Github user clindsay commented on the issue: https://github.com/apache/thrift/pull/1031 I have written unit tests for this change, but am not sure where to contribute them. I see no "cocoa" directory under the "test" directory. Is there another place where I ca

[GitHub] thrift pull request #1031: THRIFT-3859: Add support for Unix Domain Sockets ...

2016-06-21 Thread clindsay
GitHub user clindsay opened a pull request: https://github.com/apache/thrift/pull/1031 THRIFT-3859: Add support for Unix Domain Sockets to TSocketServer and TSocketTransport Existing behavior for port-based socket transport should be unchanged by this commit. TSocketServer