Github user ctubbsii commented on the issue:
https://github.com/apache/thrift/pull/1186
@Jens-G I will look and comment on THRIFT-4239.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100917042
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -5265,6 +5274,9 @@ THRIFT_REGISTER_GENERATOR(
"android_legacy
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100901172
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -5265,6 +5274,9 @@ THRIFT_REGISTER_GENERATOR(
"android_legacy
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100873930
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -5265,6 +5274,9 @@ THRIFT_REGISTER_GENERATOR(
"android_legacy
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100623293
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -91,6 +92,8 @@ class t_java_generator : public t_oop_generator
Github user ctubbsii commented on the issue:
https://github.com/apache/thrift/pull/1186
I'm not familiar enough with Thrift's testing framework to add tests, but
this works tested locally.
I don't know if this makes sense for other languages, but it seems to make
a lot of sense
GitHub user ctubbsii opened a pull request:
https://github.com/apache/thrift/pull/1186
THRIFT-1805 Provide option for handling RTEs
Adds a Java option to the generator to generate code which lets Thrift
handle RuntimeExceptions from a service, and present them
