[GitHub] thrift pull request #1524: THRIFT-4535: XML docs; code cleanup (tabs->spaces...

2018-03-30 Thread cwe1ss
GitHub user cwe1ss opened a pull request: https://github.com/apache/thrift/pull/1524 THRIFT-4535: XML docs; code cleanup (tabs->spaces; String->string) As discussed in [THRIFT-4535](https://issues.apache.org/jira/browse/THRIFT-4535) we'd like to go back to just one .

[GitHub] thrift pull request #1524: THRIFT-4535: XML docs; code cleanup (tabs->spaces...

2018-03-31 Thread cwe1ss
Github user cwe1ss commented on a diff in the pull request: https://github.com/apache/thrift/pull/1524#discussion_r178431239 --- Diff: lib/csharp/src/Protocol/TCompactProtocol.cs --- @@ -7,7 +7,7 @@ * "License"); you may not use this file except in compliance

[GitHub] thrift issue #1524: THRIFT-4535: XML docs; code cleanup (tabs->spaces; Strin...

2018-03-31 Thread cwe1ss
Github user cwe1ss commented on the issue: https://github.com/apache/thrift/pull/1524 The last AppVeyor failure seems to be unrelated: >The following tests FAILED: > 30 - HaskellCabalCheck (Failed) I fixed the license header in another commit so we

[GitHub] thrift pull request #1532: [WIP] THRIFT-4541: Use new project system in lib/...

2018-04-03 Thread cwe1ss
GitHub user cwe1ss opened a pull request: https://github.com/apache/thrift/pull/1532 [WIP] THRIFT-4541: Use new project system in lib/csharp See [THRIFT-4541](https://issues.apache.org/jira/browse/THRIFT-4541). This is a WIP/PoC and **MUST NOT BE MERGED** (because