Github user dkochmanski commented on the issue:
https://github.com/apache/thrift/pull/1412
Basically SBCL 1.3.14 (artful) works fine locally on Docker (and 1.3.1 had
a bug with base strings according to SBCL devs - xenial). So the problem is
probably something on environment hosting
Github user dkochmanski commented on the issue:
https://github.com/apache/thrift/pull/1412
Could it be that `docker` sets a "fresh" environment for each command? SBCL
keeps its cache files in ~/.cache/common-lisp and it looks like docker either
runs commands as diffe
Github user dkochmanski commented on the issue:
https://github.com/apache/thrift/pull/1412
It seems that SBCL has some problems when ran in docker (investigating that
â sadly I can't reproduce this problem on my local machine). I'll install
SBCL 1.3.1 on my machine to make 100
Github user dkochmanski commented on the issue:
https://github.com/apache/thrift/pull/1412
and one more change: ensure-externals uses `[[` syntax, so it must be run
with bash (not sh) â modified makefile and script to take this requirement
into account.
---
Github user dkochmanski commented on the issue:
https://github.com/apache/thrift/pull/1412
@jeking3 Thanks for the pointers. I've added requested info and updated
Dockerfiles. Also rebased against master.
---
Github user dkochmanski commented on the issue:
https://github.com/apache/thrift/pull/1412
any update on this? I'm fine with both options (given all parties agree on
them) and have time to work on code forward.
---
Github user dkochmanski commented on the issue:
https://github.com/apache/thrift/pull/1412
Good news, I have consent from @pc to change the header of the generator to
match contributor guidelines. So next steps are:
- merge changes to de.setf.thrift repository (so missing
Github user dkochmanski commented on the issue:
https://github.com/apache/thrift/pull/1412
The bottom line is this: under the law of where mr. Anderson lives he can't
yield the IP rights nor he sees a reason to do so, so we can't remove the
copyrights put by him there. Code
Github user dkochmanski commented on the issue:
https://github.com/apache/thrift/pull/1410
Hello, I've send you an email a few hours ago with a question, if we can
remove your "copyright" headers from the code found in de.setf.thrift, because
that is what is required by T
Github user dkochmanski commented on the issue:
https://github.com/apache/thrift/pull/1410
see https://github.com/apache/thrift/pull/1412
---
Github user dkochmanski commented on the issue:
https://github.com/apache/thrift/pull/1412
squashed and rebased on top of the thrift master head.
---
GitHub user dkochmanski opened a pull request:
https://github.com/apache/thrift/pull/1412
[THRIFT-82] Add Common Lisp support
There's framed and buffered socket transport, binary protocol, multiplex,
simple
server, cross-tests, self-tests, tutorial, CL library, CL code
Github user dkochmanski commented on the issue:
https://github.com/apache/thrift/pull/1410
@jfarrell logged into travis a moment ago for the first time.
@jeking3 I'm waiting for a response from @lisp if we can remove his
copyright strings (we've removed ours). Should I close
Github user dkochmanski commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r149660082
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti
Github user dkochmanski commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r149592614
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti
Github user dkochmanski commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r149491753
--- Diff: lib/cl/ensure-externals.sh ---
@@ -0,0 +1,12 @@
+#!/bin/sh
+
+set -e
+
+if [ ! -d "externals/" ] ; then
--
Github user dkochmanski commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r149489770
--- Diff: lib/cl/server.lisp ---
@@ -0,0 +1,230 @@
+(in-package #:org.apache.thrift.implementation)
--- End diff --
it is a common
Github user dkochmanski commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r149489004
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti
Github user dkochmanski commented on the issue:
https://github.com/apache/thrift/pull/1410
Thank you for taking your time for the review
---
Github user dkochmanski commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148797236
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti
Github user dkochmanski commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r148796969
--- Diff: lib/cl/externals/bundle-info.sexp ---
@@ -0,0 +1,14 @@
+(:CREATION-TIME #A((20) BASE-CHAR . "2017-10-31T11:49:23Z")
:REQUEST
Github user dkochmanski closed the pull request at:
https://github.com/apache/thrift/pull/1394
---
Github user dkochmanski commented on the issue:
https://github.com/apache/thrift/pull/1394
sorry, wrong PR target.
---
GitHub user dkochmanski opened a pull request:
https://github.com/apache/thrift/pull/1394
minor fixes to tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TurtleWarePL/thrift develop-jd
Alternatively you can review
24 matches
Mail list logo
