[GitHub] thrift pull request #1294: THRIFT-4233 Make THsHaServer.invoker available (g...

2017-06-23 Thread dmvolod
GitHub user dmvolod opened a pull request: https://github.com/apache/thrift/pull/1294 THRIFT-4233 Make THsHaServer.invoker available (get method only) in inherited classes You can merge this pull request into a Git repository by running: $ git pull https://github.com/dmvolod

[GitHub] thrift issue #1294: THRIFT-4233 Make THsHaServer.invoker available (get meth...

2017-08-08 Thread dmvolod
Github user dmvolod commented on the issue: https://github.com/apache/thrift/pull/1294 Is there any chance to review this changes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] thrift pull request #1294: THRIFT-4233 Make THsHaServer.invoker available (g...

2017-09-21 Thread dmvolod
Github user dmvolod commented on a diff in the pull request: https://github.com/apache/thrift/pull/1294#discussion_r140350410 --- Diff: lib/java/src/org/apache/thrift/server/THsHaServer.java --- @@ -154,7 +154,10 @@ protected static ExecutorService createInvokerPool(Args options

[GitHub] thrift pull request #1366: THRIFT-4233 Make THsHaServer.invoker available (g...

2017-09-21 Thread dmvolod
GitHub user dmvolod opened a pull request: https://github.com/apache/thrift/pull/1366 THRIFT-4233 Make THsHaServer.invoker available (get method only) in inherited classes … You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] thrift pull request #1294: THRIFT-4233 Make THsHaServer.invoker available (g...

2017-09-21 Thread dmvolod
Github user dmvolod closed the pull request at: https://github.com/apache/thrift/pull/1294 ---

[GitHub] thrift issue #1366: THRIFT-4233 Make THsHaServer.invoker available (get meth...

2017-09-21 Thread dmvolod
Github user dmvolod commented on the issue: https://github.com/apache/thrift/pull/1366 @jeking3 , please review. The static is not acceptable to getInvoker as invoker is not static context ---

[GitHub] thrift pull request #1446: Insert files related to eclipse project to gitign...

2017-12-18 Thread dmvolod
GitHub user dmvolod opened a pull request: https://github.com/apache/thrift/pull/1446 Insert files related to eclipse project to gitignore You can merge this pull request into a Git repository by running: $ git pull https://github.com/dmvolod/thrift gitignore-add

[GitHub] thrift pull request #1477: THRIFT-4470 Include popular IDE file templates to...

2018-01-23 Thread dmvolod
GitHub user dmvolod opened a pull request: https://github.com/apache/thrift/pull/1477 THRIFT-4470 Include popular IDE file templates to gitignore You can merge this pull request into a Git repository by running: $ git pull https://github.com/dmvolod/thrift THRIFT-4470

[GitHub] thrift pull request #1485: THRIFT-4429: Make TThreadPoolServer.executorServi...

2018-01-30 Thread dmvolod
GitHub user dmvolod opened a pull request: https://github.com/apache/thrift/pull/1485 THRIFT-4429: Make TThreadPoolServer.executorService_ available in inherited classes and refactor methods to be able customization Plus some classes cleanup from unused imports You can merge this

[GitHub] thrift pull request #1486: THRIFT-4337: Able to set keyStore and trustStore ...

2018-01-30 Thread dmvolod
GitHub user dmvolod opened a pull request: https://github.com/apache/thrift/pull/1486 THRIFT-4337: Able to set keyStore and trustStore as InputStream in the TSSLTransportFactory.TSSLTransportParameters Plus some tests cleanup You can merge this pull request into a Git repository

[GitHub] thrift issue #1485: THRIFT-4429: Make TThreadPoolServer.executorService_ ava...

2018-02-26 Thread dmvolod
Github user dmvolod commented on the issue: https://github.com/apache/thrift/pull/1485 @jeking3 , could you please to look at this PR. Thanks in advance. ---

[GitHub] thrift issue #1486: THRIFT-4337: Able to set keyStore and trustStore as Inpu...

2018-02-26 Thread dmvolod
Github user dmvolod commented on the issue: https://github.com/apache/thrift/pull/1486 @jeking3 , could you please to look at this PR. Thanks in advance. ---

[GitHub] thrift issue #1486: THRIFT-4337: Able to set keyStore and trustStore as Inpu...

2018-03-12 Thread dmvolod
Github user dmvolod commented on the issue: https://github.com/apache/thrift/pull/1486 Done rebase. Thanks, @jeking3 . ---

[GitHub] thrift issue #1485: THRIFT-4429: Make TThreadPoolServer.executorService_ ava...

2018-03-13 Thread dmvolod
Github user dmvolod commented on the issue: https://github.com/apache/thrift/pull/1485 Thanks a lot for review. ---