Github user econner commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1304#discussion_r126207049
--- Diff: lib/go/thrift/server_socket.go ---
@@ -68,15 +68,18 @@ func (p *TServerSocket) Listen() error {
func (p *TServerSocket) Accept
GitHub user econner opened a pull request:
https://github.com/apache/thrift/pull/1305
Fix whitespace for flake8.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/econner/thrift fix-flake8
Alternatively you can review and apply
Github user econner commented on the issue:
https://github.com/apache/thrift/pull/1300
Does running ``make check`` from ``/thrift/src/test/go`` not do what you
want?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user econner commented on the issue:
https://github.com/apache/thrift/pull/1302
Hi @zwass,
It seems one of your recent changes has broken the build. Can you please
take a look?
https://travis-ci.org/apache/thrift/builds/249109561
Thanks.
---
If your
Github user econner commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1293#discussion_r125777018
--- Diff: test/py/SerializationTest.py ---
@@ -285,6 +290,67 @@ def testIntegerLimits(self):
for value in bad_values
Github user econner commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1293#discussion_r125776924
--- Diff: lib/py/src/ext/types.cpp ---
@@ -20,6 +20,8 @@
#include "ext/types.h"
#include "ext/protocol.h"
+#inclu
Github user econner commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1293#discussion_r125776706
--- Diff: compiler/cpp/src/thrift/generate/t_py_generator.cc ---
@@ -610,11 +623,22 @@ string t_py_generator::render_const_value(t_type*
type
Github user econner commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1293#discussion_r125751862
--- Diff: lib/py/src/TRecursive.py ---
@@ -0,0 +1,63 @@
+# MODIFIED June 20, 2017, Eric Conner
+#
+#
+# Original source copyright 2014
GitHub user econner opened a pull request:
https://github.com/apache/thrift/pull/1296
THRIFT-4234 Travis build fails cross language tests with "Unsupported
security protocol type"
Fix is to upgrade Mono to latest version.
See https://issues.apache.org/jira/bro
GitHub user econner opened a pull request:
https://github.com/apache/thrift/pull/1295
THRIFT-4213 Travis build fails at curl -sSL
https://www.npmjs.com/install.sh | sh
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/econner
Github user econner commented on the issue:
https://github.com/apache/thrift/pull/1293
Ok, I've updated the PR to use a list (reference type) instead of a tuple.
I also added some serialization tests for recursive structures. Hopefully
everything works now.
---
If your project
GitHub user econner reopened a pull request:
https://github.com/apache/thrift/pull/1293
THRIFT-2642 Recursive structs don't work in python
See https://issues.apache.org/jira/browse/THRIFT-2642.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user econner closed the pull request at:
https://github.com/apache/thrift/pull/1293
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user econner commented on the issue:
https://github.com/apache/thrift/pull/1293
As written this will not work. The spec for a Struct needs to be a
reference type such as a list for recursion to work correctly so there is more
work to be done here.
---
If your project is set
GitHub user econner opened a pull request:
https://github.com/apache/thrift/pull/1293
THRIFT-2642 Recursive structs don't work in python
See https://issues.apache.org/jira/browse/THRIFT-2642.
You can merge this pull request into a Git repository by running:
$ git pull https
15 matches
Mail list logo
