[GitHub] thrift pull request: THRIFT-3306: Java: TBinaryProtocol: Use a sin...

2015-09-29 Thread evanj
Github user evanj commented on the pull request: https://github.com/apache/thrift/pull/596#issuecomment-144037231 Note: the Travis CI build may have failed, but it failed to compile some parts of the C++ code, so I suspect this is due to a flaky test and is not legitimate, since I

[GitHub] thrift pull request: THRIFT-3306: Java: TBinaryProtocol: Use a sin...

2015-08-25 Thread evanj
GitHub user evanj opened a pull request: https://github.com/apache/thrift/pull/596 THRIFT-3306: Java: TBinaryProtocol: Use a single temp byte[] buffer Reduces allocations and GC when TBinaryProtocol is allocated repeatedly. Originally separate byte[] arrays were allocated

[GitHub] thrift pull request: THRIFT-2536: Java: TBinaryProtocol: Use a sin...

2015-08-25 Thread evanj
GitHub user evanj opened a pull request: https://github.com/apache/thrift/pull/595 THRIFT-2536: Java: TBinaryProtocol: Use a single temp byte[] buffer Reduces allocations and GC when TBinaryProtocol is allocated repeatedly. Originally separate byte[] arrays were allocated

[GitHub] thrift pull request: THRIFT-2536: Java: TBinaryProtocol: Use a sin...

2015-08-25 Thread evanj
Github user evanj closed the pull request at: https://github.com/apache/thrift/pull/595 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift pull request: THRIFT-2536: Java: TBinaryProtocol: Use a sin...

2015-08-25 Thread evanj
Github user evanj commented on the pull request: https://github.com/apache/thrift/pull/595#issuecomment-134644963 Sorry, I copy-and-pasted the wrong ticket number. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your