GitHub user klickverbot opened a pull request:
https://github.com/apache/thrift/pull/245
THRIFT-2782: D: Timing-insensitive unit tests for
thrift.internal.resource_pool.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user klickverbot commented on the pull request:
https://github.com/apache/thrift/pull/245#issuecomment-58709801
@Jens-G: Since you seem to be merging the pull requests manually anyway, I
added two code quality improvements as separate commits.
---
If your project is set up
Github user klickverbot commented on the pull request:
https://github.com/apache/thrift/pull/237#issuecomment-58164748
@Jens-G: I didn't realize that there are supposed to be tickets for trivial
code changes such as this too (changelog generation?). Filed two bugs and
updated
GitHub user klickverbot opened a pull request:
https://github.com/apache/thrift/pull/237
D: Fix thrift.internal.traits unittest build.
I originally wrote what became std.traits.SetFunctionAttributes
as thrift.internal.traits.ChangeFuncAttrs. Now that it has been
in Phobos
GitHub user klickverbot opened a pull request:
https://github.com/apache/thrift/pull/236
D: Fix pointerTarget deprecation warning.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/klickverbot/thrift d-pointer-target
Github user klickverbot commented on the pull request:
https://github.com/apache/thrift/pull/220#issuecomment-56197949
Looks good to me (the original author), please merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
