Github user kufd commented on the issue:
https://github.com/apache/thrift/pull/1215
There is a falg "validate" in thrift generator for php (validate:
Generate PHP validator methods\n")
And that flag is used in my changes
I will try to add tests for b
Github user kufd commented on the issue:
https://github.com/apache/thrift/pull/1215
Yes
I will add functional tests
But it can take a few weeks, because i do not have enough free time now
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kufd commented on the issue:
https://github.com/apache/thrift/pull/1215
Now all build jobs are success
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user kufd commented on the issue:
https://github.com/apache/thrift/pull/1215
Hi @jeking3
I looked into the failed builds. But errors are not related to my changes.
Maybe i should wait for some time and merge changes from thrift repo into
my branch.
---
If your
GitHub user kufd opened a pull request:
https://github.com/apache/thrift/pull/1215
Thrift 4126
Hello
It is a pull request with required fields validation for php extension
Here is jira issue https://issues.apache.org/jira/browse/THRIFT-4126
You can merge this pull request
Github user kufd commented on the issue:
https://github.com/apache/thrift/pull/1014
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kufd commented on the issue:
https://github.com/apache/thrift/pull/1014
I have merged changes from original thrift repo
But problems are still present
One travis job is failed because of timeout
AppVeyor is not finished yet
Should i merge changes again
Github user kufd commented on the issue:
https://github.com/apache/thrift/pull/1014
We use this fix in our prod and it works as mentioned.
But as i can see the build is failed not because of my changes
So i am just waiting for review from commiters.
---
If your project
GitHub user kufd opened a pull request:
https://github.com/apache/thrift/pull/1014
Thrift 3839
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kufd/thrift THRIFT-3839
Alternatively you can review and apply these changes as the
