[GitHub] thrift pull request #434: Fix THRIFT-3090 (cmake build is broken)

Github user marco-m closed the pull request at: https://github.com/apache/thrift/pull/434 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift pull request: THRIFT-3099 cmake build is broken on FreeBSD

Github user marco-m closed the pull request at: https://github.com/apache/thrift/pull/446 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift pull request: Thrift 3097

Github user marco-m closed the pull request at: https://github.com/apache/thrift/pull/443 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift pull request: Thrift 3103

Github user marco-m closed the pull request at: https://github.com/apache/thrift/pull/449 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift pull request: Thrift 3103

Github user marco-m commented on the pull request: https://github.com/apache/thrift/pull/449#issuecomment-97174455 @bufferoverflow done, thanks for accepting the PR :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] thrift pull request: Thrift 3103

Github user marco-m commented on the pull request: https://github.com/apache/thrift/pull/449#issuecomment-94012877 Actually this pull request is only about THRIFT-3103, but you see also the previous THRIFT-3090 commit (which has a separate pull request, https://github.com/apache

[GitHub] thrift pull request: THRIFT-3099 cmake build is broken on FreeBSD

GitHub user marco-m opened a pull request: https://github.com/apache/thrift/pull/446 THRIFT-3099 cmake build is broken on FreeBSD See https://issues.apache.org/jira/browse/THRIFT-3099 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] thrift pull request: Thrift 3097

GitHub user marco-m opened a pull request: https://github.com/apache/thrift/pull/443 Thrift 3097 See https://issues.apache.org/jira/browse/THRIFT-3097 You can merge this pull request into a Git repository by running: $ git pull https://github.com/marco-m/thrift THRIFT-3097

[GitHub] thrift pull request: Fix THRIFT-3090 (cmake build is broken)

Github user marco-m commented on a diff in the pull request: https://github.com/apache/thrift/pull/434#discussion_r28203820 --- Diff: lib/cpp/CMakeLists.txt --- @@ -26,7 +26,7 @@ if(WITH_BOOSTTHREADS) else() find_package(Boost 1.53.0 REQUIRED) endif

[GitHub] thrift pull request: Fix THRIFT-3090 (cmake build is broken)

Github user marco-m commented on a diff in the pull request: https://github.com/apache/thrift/pull/434#discussion_r28203837 --- Diff: build/cmake/DefinePlatformSpecifc.cmake --- @@ -58,8 +58,9 @@ if(MSVC) endif(WITH_MT) endif(MSVC) -# GCC Specific

[GitHub] thrift pull request: Fix THRIFT-3090 (cmake build is broken)

GitHub user marco-m opened a pull request: https://github.com/apache/thrift/pull/434 Fix THRIFT-3090 (cmake build is broken) Problem found and fixed on Mac OS X 10.10.3, but at least the link problems must happen on every OS. You can merge this pull request into a Git repository