[GitHub] thrift issue #1462: Add seek function to TCompactInputProtocol

2018-01-08 Thread mrwiggles
Github user mrwiggles commented on the issue: https://github.com/apache/thrift/pull/1462 @vchekan Minor formatting nit, otherwise, LGTM! ---

[GitHub] thrift pull request #1462: Add seek function to TCompactInputProtocol

2018-01-08 Thread mrwiggles
Github user mrwiggles commented on a diff in the pull request: https://github.com/apache/thrift/pull/1462#discussion_r160317863 --- Diff: lib/rs/src/protocol/compact.rs --- @@ -314,6 +315,17 @@ where } } + +impl io::Seek for TCompactInputProtocol

[GitHub] thrift issue #1360: THRIFT-4330: Allow unused extern crates

2017-09-15 Thread mrwiggles
Github user mrwiggles commented on the issue: https://github.com/apache/thrift/pull/1360 @sadikovi The change seems fine, but I don't understand when this warning gets triggered. Could you explain a bit more what you mean? When does this happen, and why? Thanks! ---

[GitHub] thrift issue #1138: Add union example to ThriftTest

2016-12-12 Thread mrwiggles
Github user mrwiggles commented on the issue: https://github.com/apache/thrift/pull/1138 Thanks @Jens-G --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so