GitHub user msridhar opened a pull request:
https://github.com/apache/thrift/pull/1522
THRIFT-4530: add @Nullable annotations to generated Java code
Use our own `org.apache.thrift.annotations.Nullable` annotation to avoid
introducing a third-party dependency
You can merge this
Github user msridhar commented on the issue:
https://github.com/apache/thrift/pull/1522
Note that while there are no new tests, the code under
`tutorial/java/gen-java` includes the annotations and compiles without issue.
Since this change doesn't affect runtime behavior o
Github user msridhar commented on the issue:
https://github.com/apache/thrift/pull/1522
Looks like the Travis failure is on Common Lisp codegen
(https://api.travis-ci.org/v3/job/359136811/log.txt), which has nothing to do
with this PR
---
Github user msridhar commented on the issue:
https://github.com/apache/thrift/pull/1522
I just pushed up another commit with the renaming. I assume you can do a
squash and merge, but if you'd like me to squash just let me know.
---
Github user msridhar commented on the issue:
https://github.com/apache/thrift/pull/1522
Hrm, now I see a concurrency test failure on appveyor. Doesn't seem
related to my change, though I'm not 100% sure.
---
