Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/938#issuecomment-197734222
@nsuke All checks done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mygityf closed the pull request at:
https://github.com/apache/thrift/pull/949
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/948#issuecomment-196685223
@nsuke can you merge the pull into master,
Then i can try to rebase #938
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/938#issuecomment-196609164
CI Error:
precision lost from double to string.
https://github.com/apache/thrift/pull/948
https://github.com/gityf/thrift/commit
GitHub user mygityf opened a pull request:
https://github.com/apache/thrift/pull/948
THRIFT-3744 The precision should be 17 (16 bits need after dot) after dot
for double type.
The precision is lost when converting double to string.
E.g:
double PI = 3.1415926535897931
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/942#issuecomment-195268573
@nsuke
CI error is 'Failed to install HUnit-1.3.1.1', how to fix it?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/938#issuecomment-195241808
CI looks failure in cases of d-lua http-ip with all protocol.
it is bug in thrift-d library at file http.d.
#942
---
If your project is set up for it, you can
GitHub user mygityf opened a pull request:
https://github.com/apache/thrift/pull/942
THRIFT-3734 To compare two string as lowercase.
it looks unexpected result got when parameter a is uppercase and b is
lowercase.
split[0] is string of 'Content-Length', it contains character
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/938#issuecomment-194625488
Jenkins and CI errorï¼
NoMethodError: undefined method `last_comment' for
#
/var/lib/gems/1.9.1/gems/rspec-core-2.10.1/lib/rspec/core/rake_task.rb:124
GitHub user mygityf opened a pull request:
https://github.com/apache/thrift/pull/938
THRIFT-3728 http transport for thrift-lua
THttpTransport.lua is http transport implement for thrift-lua.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user mygityf closed the pull request at:
https://github.com/apache/thrift/pull/864
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/864#issuecomment-185568709
@nsuke Integer is convert to string without dot. can you try again in your
env to check whether it work well or not, thanks.
---
If your project is set up for it, you
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/864#issuecomment-185525091
@nsuke issue of i8(byte) and i32 values are encoded like 1.0 instead of 1.
It is reproduced in receiver side or sender side or both side?
---
If your project
Github user mygityf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/864#discussion_r53265228
--- Diff: lib/lua/TJsonProtocol.lua ---
@@ -0,0 +1,725 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/870#issuecomment-184704422
@nsuke just do it to make it better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/870#issuecomment-184556899
@nsuke I replace the PI and golden ratio with float literals and use the
same digits(17) in file lib/cpp/test/JSONProtoTest.cpp.
The result looks OK in Jenkins
Github user mygityf commented on a diff in the pull request:
https://github.com/apache/thrift/pull/870#discussion_r52961339
--- Diff: lib/cpp/src/thrift/protocol/TJSONProtocol.cpp ---
@@ -524,7 +524,8 @@ namespace {
std::string doubleToString(double d) {
std
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/870#issuecomment-184066476
using 17 directly with a comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/864#issuecomment-184037495
The solution to the test failure:
pull request for C++ thrift https://github.com/apache/thrift/pull/870.
---
If your project is set up for it, you can reply
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/864#issuecomment-184034288
The precision is 15 bits after dot of format casting from double to string
in Thrift-cpp-library- json-protocol.
But the precision is 16 bits after dot in Thrift-lua
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/864#issuecomment-183865602
@nsuke
I move THRIFT-3631 to new branch and keep only the THRIFT-3631 commit in
this pull request.
---
If your project is set up for it, you can reply
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/863#issuecomment-183872571
pull request is moved to https://github.com/apache/thrift/pull/864 #864
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mygityf closed the pull request at:
https://github.com/apache/thrift/pull/863
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user mygityf opened a pull request:
https://github.com/apache/thrift/pull/864
THRIFT-3631 Lua- JSON protocol implement for thrift-lua library.
THRIFT-3631 Lua-This is JSON protocol implement for thrift-lua library.
TJsonProtocol.lua is new source of lua for thrift JSON
GitHub user mygityf reopened a pull request:
https://github.com/apache/thrift/pull/863
THRIFT-3631 Lua-This is JSON protocol implement for thrift-lua library.
TJsonProtocol.lua is new source of lua for thrift JSON protocol.
Test result is expected of test_basic_server.lua
Github user mygityf closed the pull request at:
https://github.com/apache/thrift/pull/863
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user mygityf opened a pull request:
https://github.com/apache/thrift/pull/863
THRIFT-3631 Lua-This is JSON protocol implement for thrift-lua library.
TJsonProtocol.lua is new source of lua for thrift JSON protocol.
Test result is expected of test_basic_server.lua
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/828#issuecomment-179694517
Tested with test/lua/test_basic_client.lua and test_basic_server.lua,
result is expected.
new comment(df693bf) added for the bug.
---
If your project is set up
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/826#issuecomment-178964162
To read a field by field id instead of argument of 'self ' in reading side.
The problem can not be reproduced in reading side.
---
If your project is set up
Github user mygityf closed the pull request at:
https://github.com/apache/thrift/pull/827
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user mygityf opened a pull request:
https://github.com/apache/thrift/pull/828
THRIFT-3585 Lua: compact protocol implement of lua for thrift.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gityf/thrift master
Github user mygityf closed the pull request at:
https://github.com/apache/thrift/pull/824
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user mygityf opened a pull request:
https://github.com/apache/thrift/pull/826
THRIFT-3584 Lua: To check element of self whether nil or not,avoid the
value(false) of BOOL is lost.
â¦e value(false) of BOOL is lost.
eg.
Before:
if self.argBool
GitHub user mygityf opened a pull request:
https://github.com/apache/thrift/pull/827
THRIFT-3585 Lua: compact protocol implement of lua for thrift.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gityf/thrift lua-library
Github user mygityf commented on the pull request:
https://github.com/apache/thrift/pull/824#issuecomment-176135894
Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user mygityf opened a pull request:
https://github.com/apache/thrift/pull/824
To check element of self whether nil or not,avoid the value(false) ofâ¦
⦠BOOL is lost.
eg.
Before:
if self.argBool then
oprot:writeFieldBegin('argBool', TType.BOOL, 13
36 matches
Mail list logo
