[GitHub] thrift issue #1407: THRIFT-4377: close socket after processing request

2017-10-30 Thread oprudkyi
Github user oprudkyi commented on the issue: https://github.com/apache/thrift/pull/1407 @jeking3 , Sorry, there was my fault - haxe php integration was broken by first commit and I added fixes ---

[GitHub] thrift pull request #1407: THRIFT-4377: close socket after processing reques...

2017-10-29 Thread oprudkyi
GitHub user oprudkyi opened a pull request: https://github.com/apache/thrift/pull/1407 THRIFT-4377: close socket after processing request You can merge this pull request into a Git repository by running: $ git pull https://github.com/oprudkyi/thrift THRIFT-4377 Alternatively

[GitHub] thrift issue #1045: THRIFT-3876 haxe js/nodejs client

2017-04-06 Thread oprudkyi
Github user oprudkyi commented on the issue: https://github.com/apache/thrift/pull/1045 I don't care either , I had the particular issue and shared fix for the issue I do not have time to create JIRAs for unrelated stuff nor to implement cross-platform things . of c

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-16 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71066420 --- Diff: lib/haxe/src/org/apache/thrift/transport/THttpClient.hx --- @@ -94,10 +114,241 @@ class THttpClient extends TTransport

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-16 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71066333 --- Diff: lib/haxe/src/org/apache/thrift/transport/THttpClient.hx --- @@ -39,12 +46,25 @@ class THttpClient extends TTransport { private var

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-16 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71066191 --- Diff: test/haxe/src/Main.hx --- @@ -46,11 +46,14 @@ class Main if( args.printHelpOnly) return

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-16 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71065930 --- Diff: lib/haxe/src/org/apache/thrift/transport/TFileStream.hx --- @@ -24,6 +24,9 @@ import haxe.io.BytesBuffer; import haxe.io.Input; import

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-15 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71057451 --- Diff: lib/haxe/src/org/apache/thrift/transport/THttpClient.hx --- @@ -94,10 +114,241 @@ class THttpClient extends TTransport

[GitHub] thrift issue #1045: THRIFT-3876 haxe js/nodejs client

2016-07-15 Thread oprudkyi
Github user oprudkyi commented on the issue: https://github.com/apache/thrift/pull/1045 @Jens-G >phantom-js-client.test.js should have one. ASF header has been added --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-15 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71055190 --- Diff: lib/haxe/src/org/apache/thrift/transport/THttpClient.hx --- @@ -94,10 +114,241 @@ class THttpClient extends TTransport

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-15 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71054757 --- Diff: lib/haxe/src/org/apache/thrift/transport/THttpClient.hx --- @@ -94,10 +114,241 @@ class THttpClient extends TTransport

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-15 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71054064 --- Diff: lib/haxe/src/org/apache/thrift/transport/THttpClient.hx --- @@ -94,10 +114,241 @@ class THttpClient extends TTransport

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-15 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71053129 --- Diff: lib/haxe/src/org/apache/thrift/transport/THttpClient.hx --- @@ -39,12 +46,25 @@ class THttpClient extends TTransport { private var

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-15 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71052874 --- Diff: test/haxe/src/Main.hx --- @@ -46,11 +46,14 @@ class Main if( args.printHelpOnly) return

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-15 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71052800 --- Diff: lib/haxe/src/org/apache/thrift/transport/TFileStream.hx --- @@ -24,6 +24,9 @@ import haxe.io.BytesBuffer; import haxe.io.Input; import

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-10 Thread oprudkyi
GitHub user oprudkyi opened a pull request: https://github.com/apache/thrift/pull/1045 THRIFT-3876 haxe js/nodejs client - only http transport is supported - testing of browser js made via phantomjs - tutorial of browser js uses haxe-php web server for files delivery

[GitHub] thrift pull request: THRIFT-3833 haxe http php server implementati...

2016-05-21 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1013#discussion_r64140128 --- Diff: tutorial/haxe/src/Main.hx --- @@ -51,14 +51,44 @@ class Main { private static var targetPort : Int = 9090; static function

[GitHub] thrift pull request: THRIFT-3833 haxe http php server implementati...

2016-05-21 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1013#discussion_r64140086 --- Diff: tutorial/haxe/src/Main.hx --- @@ -51,14 +51,44 @@ class Main { private static var targetPort : Int = 9090; static function

[GitHub] thrift pull request: THRIFT-3833 haxe http php server implementati...

2016-05-21 Thread oprudkyi
Github user oprudkyi commented on the pull request: https://github.com/apache/thrift/pull/1013#issuecomment-220784815 I've filed issue to the haxe https://github.com/HaxeFoundation/haxe/issues/5264 --- If your project is set up for it, you can reply to this email and have your

[GitHub] thrift pull request: THRIFT-3833 haxe http php server implementati...

2016-05-21 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1013#discussion_r64133771 --- Diff: test/haxe/router.php --- @@ -0,0 +1,9 @@ +

[GitHub] thrift pull request: THRIFT-3833 haxe http php server implementati...

2016-05-21 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1013#discussion_r64133704 --- Diff: tutorial/haxe/src/Main.hx --- @@ -51,14 +51,44 @@ class Main { private static var targetPort : Int = 9090; static function

[GitHub] thrift pull request: THRIFT-3833 haxe http php server implementati...

2016-05-19 Thread oprudkyi
GitHub user oprudkyi opened a pull request: https://github.com/apache/thrift/pull/1013 THRIFT-3833 haxe http php server implementation (embeding into php web server) - support of TSimpleServer.runOnce (run till input EOF) - TWrappingServerTransport wraps TTransport into