Github user timse commented on the pull request:
https://github.com/apache/thrift/pull/379#issuecomment-166823413
anything else needed for this to proceed @nsuke ?
not sure what to do with the one failing test/if it has anything to do with
these changes
---
If your project is
Github user timse commented on a diff in the pull request:
https://github.com/apache/thrift/pull/379#discussion_r48103666
--- Diff: lib/nodejs/lib/thrift/json_protocol.js ---
@@ -89,9 +89,16 @@ TJSONProtocol.RType.set = Type.SET;
TJSONProtocol.Version = 1
Github user timse commented on a diff in the pull request:
https://github.com/apache/thrift/pull/379#discussion_r48103629
--- Diff: lib/nodejs/lib/thrift/json_protocol.js ---
@@ -89,9 +89,16 @@ TJSONProtocol.RType.set = Type.SET;
TJSONProtocol.Version = 1
Github user timse commented on the pull request:
https://github.com/apache/thrift/pull/379#issuecomment-161125749
any news on this @RandyAbernethy
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user timse commented on the pull request:
https://github.com/apache/thrift/pull/707#issuecomment-161122846
there were a couple of syntax errors so i allowed myself to force push fix
them
should be fixed now @nsuke
---
If your project is set up for it, you can reply to
Github user timse commented on the pull request:
https://github.com/apache/thrift/pull/707#issuecomment-160294562
any news on this? would that change do the job @cjthompson?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user timse commented on the pull request:
https://github.com/apache/thrift/pull/379#issuecomment-145812777
i did changes, i don't really know what to do with the failing, tests. Are
they related to my changes?
---
If your project is set up for it, you can reply to this
Github user timse commented on the pull request:
https://github.com/apache/thrift/pull/379#issuecomment-145458444
any news on that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user timse opened a pull request:
https://github.com/apache/thrift/pull/379
Trying to fix json protocol for nodejs
this fixes: https://issues.apache.org/jira/browse/THRIFT-2994 (not sure if
that is the correct way to link a jira ticket :smile: )
It initializes the
