[GitHub] thrift pull request: Add basic default hash code method to python,...

2014-08-14 Thread virtuald
Github user virtuald commented on the pull request: https://github.com/apache/thrift/pull/156#issuecomment-52236059 You could add something at the top of the file? if sys.version[0] 3 PYTHONHASHSEED = 42... not sure what the best way to deal with this otherwise would

[GitHub] thrift pull request: THRIFT-2662 Fix incorrect indentation when on...

2014-08-13 Thread virtuald
GitHub user virtuald opened a pull request: https://github.com/apache/thrift/pull/186 THRIFT-2662 Fix incorrect indentation when oneway function is used https://issues.apache.org/jira/browse/THRIFT-2662 You can merge this pull request into a Git repository by running: $ git

[GitHub] thrift pull request: THRIFT-2663: Don't use the root logger in pyt...

2014-08-13 Thread virtuald
GitHub user virtuald opened a pull request: https://github.com/apache/thrift/pull/187 THRIFT-2663: Don't use the root logger in python https://issues.apache.org/jira/browse/THRIFT-2663 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] thrift pull request: THRIFT-2664: Resolve method later, prevents e...

2014-08-13 Thread virtuald
GitHub user virtuald opened a pull request: https://github.com/apache/thrift/pull/188 THRIFT-2664: Resolve method later, prevents errors on oneway functions https://issues.apache.org/jira/browse/THRIFT-2664 You can merge this pull request into a Git repository by running

[GitHub] thrift pull request: THRIFT-2665: Debug statements are unnecessary...

2014-08-13 Thread virtuald
GitHub user virtuald opened a pull request: https://github.com/apache/thrift/pull/189 THRIFT-2665: Debug statements are unnecessary and should be removed https://issues.apache.org/jira/browse/THRIFT-2665 You can merge this pull request into a Git repository by running: $ git

[GitHub] thrift pull request: THRIFT-2665: Debug statements are unnecessary...

2014-08-13 Thread virtuald
Github user virtuald commented on the pull request: https://github.com/apache/thrift/pull/189#issuecomment-52105557 Though the CI build failed, I don't think it was due to my code change, as it was a change to the python code, and the error reported is a compiler error of some sort

[GitHub] thrift pull request: THRIFT-2663: Don't use the root logger in pyt...

2014-08-13 Thread virtuald
Github user virtuald commented on the pull request: https://github.com/apache/thrift/pull/187#issuecomment-52106737 It's not clear to me why the CI tests failed. Since it said that it ran out of time, I suspect the build server was overloaded. Is there a way to restart the tests