Github user viveksjain commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1194#discussion_r101694140
--- Diff: compiler/cpp/src/thrift/generate/t_cpp_generator.cc ---
@@ -566,6 +567,47 @@ void t_cpp_generator::generate_enum(t_enum* tenum
Github user viveksjain commented on the issue:
https://github.com/apache/thrift/pull/1083
Is there anything else needed to merge this? Seems to be a lot of stale PRs
waiting for review/merge. :(
---
If your project is set up for it, you can reply to this email and have your
reply
Github user viveksjain commented on the issue:
https://github.com/apache/thrift/pull/1083
Yeah, as I mentioned on JIRA there may be backwards compatibility concerns.
But from what I saw in the related [THRIFT-3336
comment](https://issues.apache.org/jira/browse/THRIFT-3336
Github user viveksjain commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1083#discussion_r77875285
--- Diff: compiler/cpp/src/generate/t_cpp_generator.cc ---
@@ -541,6 +542,35 @@ void t_cpp_generator::generate_enum(t_enum* tenum
GitHub user viveksjain opened a pull request:
https://github.com/apache/thrift/pull/1083
THRIFT-3921 Add C++ ostream operator<< functions for enums
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viveksjain/thrift THRIF
