Re: [3/3] thrift git commit: THRIFT-3221 Create a tool to audit network compatibility between two .thrift files Client: Compiler (general) Patch: Sanjay Poojary , Ben Craig

Moved readme.txt. Python test rewrite is going to need to wait though (unless you want to take it on). Sorry about that :( On Thu, Jul 9, 2015 at 8:22 AM, Ben Craig wrote: > I would prefer python as well. I didn't author the patch though :) I > will see about getting the test ported after a

Re: [3/3] thrift git commit: THRIFT-3221 Create a tool to audit network compatibility between two .thrift files Client: Compiler (general) Patch: Sanjay Poojary , Ben Craig

I would prefer python as well. I didn't author the patch though :) I will see about getting the test ported after a couple of weeks. I can take care of copying or moving readme.txt a little sooner. On Thu, Jul 9, 2015 at 12:14 AM, Roger Meier wrote: > Hi Ben > > Nice stuff! > Just a few remark

Re: [3/3] thrift git commit: THRIFT-3221 Create a tool to audit network compatibility between two .thrift files Client: Compiler (general) Patch: Sanjay Poojary , Ben Craig

Hi Ben Nice stuff! Just a few remarks from my side: - do we really need perl here: test/audit/thrift_audit_test.pl The cross language test suite is python and I would prefer python here - I would propose to move compiler/cpp/src/audit/readme.txt to test/audit/README.md Thanks roger Quotin