Re: [GitHub] [thrift] aaronstgeorge-wf opened a new pull request #2366: THRIFT-5383 Remove unnecessary bounds check

2021-03-30 Thread Jens Geyer
-1 the check so NOT unnecessary Sent from mobile device. You know what that means... From: GitBox Sent: Tuesday, March 30, 2021 12:41:14 AM To: dev@thrift.apache.org Subject: [GitHub] [thrift] aaronstgeorge-wf opened a new pull request #2366: THRIFT-5383

[GitHub] [thrift] aaronstgeorge-wf opened a new pull request #2366: THRIFT-5383 Remove unnecessary bounds check

2021-03-29 Thread GitBox
aaronstgeorge-wf opened a new pull request #2366: URL: https://github.com/apache/thrift/pull/2366 The added test passes with thrift 0.13.0 and fails on 0.14.0. The source of the error seems to be an unnecessary bounds check when reading JSON string. - [x] Did you