[GitHub] [thrift] dcelasun commented on pull request #2032: THRIFT-5116: Update NodeJS to supported version on Ubuntu Xenial

dcelasun commented on pull request #2032: URL: https://github.com/apache/thrift/pull/2032#issuecomment-618984445 That's a great idea actually, please go ahead and change it. This is an automated message from the Apache Git

[GitHub] [thrift] dcelasun commented on pull request #2032: THRIFT-5116: Update NodeJS to supported version on Ubuntu Xenial

dcelasun commented on pull request #2032: URL: https://github.com/apache/thrift/pull/2032#issuecomment-618937017 I've restarted it and it failed again, because there really is a bug :slightly_smiling_face: This: ``` echo "deb https://deb.nodesource.com/node_10.x xenial main" |

[GitHub] [thrift] dcelasun commented on pull request #2032: THRIFT-5116: Update NodeJS to supported version on Ubuntu Xenial

dcelasun commented on pull request #2032: URL: https://github.com/apache/thrift/pull/2032#issuecomment-618919413 Unfortunately this seems to have broken Travis: > Rebuilding docker image ubuntu-xenial > Sending build context to Docker daemon 11.26kB > Error response from

[GitHub] [thrift] dcelasun commented on pull request #2032: THRIFT-5116: Update NodeJS to supported version on Ubuntu Xenial

dcelasun commented on pull request #2032: URL: https://github.com/apache/thrift/pull/2032#issuecomment-618685580 Please also update [LANGUAGES.md](https://github.com/apache/thrift/blob/master/LANGUAGES.md) and [CHANGES.md](https://github.com/apache/thrift/blob/master/CHANGES.md#0140).