[GitHub] [thrift] dcelasun commented on pull request #2073: THRIFT-5155: Swift 5.1 support

2020-04-24 Thread GitBox
dcelasun commented on pull request #2073: URL: https://github.com/apache/thrift/pull/2073#issuecomment-619018047 Actually, the build is all green now, so I'm gonna go ahead and merge it. Thanks everyone! This is an

[GitHub] [thrift] dcelasun commented on pull request #2073: THRIFT-5155: Swift 5.1 support

2020-04-24 Thread GitBox
dcelasun commented on pull request #2073: URL: https://github.com/apache/thrift/pull/2073#issuecomment-618949715 > It is waiting for someone with commit rights to either merge this or complain :) I'm not familiar with thrift but others in this PR seem to be, so I'd be happy to

[GitHub] [thrift] dcelasun commented on pull request #2073: THRIFT-5155: Swift 5.1 support

2020-04-24 Thread GitBox
dcelasun commented on pull request #2073: URL: https://github.com/apache/thrift/pull/2073#issuecomment-618946513 @alexanderedge could you please rebase from master? The CI failures are unrelated but there have been some fixes on master and I'd like to see if we can get a green build