subject:"\[GitHub\] \[thrift\] dcelasun commented on pull request #2110\: THRIFT\-5183\: Don't try to read next frame in THeaderTransport.Read"

[GitHub] [thrift] dcelasun commented on pull request #2110: THRIFT-5183: Don't try to read next frame in THeaderTransport.Read

2020-04-24 Thread GitBox

dcelasun commented on pull request #2110: URL: https://github.com/apache/thrift/pull/2110#issuecomment-618831826 Thanks! CI failures are unrelated so I'm merging this. This is an automated message from the Apache Git

[GitHub] [thrift] dcelasun commented on pull request #2110: THRIFT-5183: Don't try to read next frame in THeaderTransport.Read

2020-04-23 Thread GitBox

dcelasun commented on pull request #2110: URL: https://github.com/apache/thrift/pull/2110#issuecomment-618662755 Nice catch @fishy! Could you maybe add a test so this won't regress in a potential refactor down the line?