emmenlau commented on issue #2094:
URL: https://github.com/apache/thrift/pull/2094#issuecomment-617121345
Ready for review.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
emmenlau commented on issue #2094:
URL: https://github.com/apache/thrift/pull/2094#issuecomment-616584968
:-( Another random error in the CI. Can this be merged anyways?
This is an automated message from the Apache Git Servic
emmenlau commented on issue #2094:
URL: https://github.com/apache/thrift/pull/2094#issuecomment-616521068
Re-triggered build with a rebase on latest master, to fix random error in
Travis CI.
This is an automated message from
emmenlau commented on issue #2094:
URL: https://github.com/apache/thrift/pull/2094#issuecomment-616505723
There seems to be an unrelated issue in
https://travis-ci.org/github/apache/thrift/jobs/677163097. Should I re-trigger
the builds and tests?
-
emmenlau commented on issue #2094:
URL: https://github.com/apache/thrift/pull/2094#issuecomment-616435582
I've found a small improvement where the Javascript target actually depends
on the target that copies the compiler into the source tree, not on the build
of the compiler. This ensures