emmenlau opened a new pull request #2118: URL: https://github.com/apache/thrift/pull/2118
This PR adds cmake support for the C# netstd implementation. The major changes are only in cmake and in the Visual Studio project files. The actual build is executed via `dotnet` (which has to be installed). cmake only orchestrates the build and can install the build artifacts. A major change is that this PR fixes issue https://issues.apache.org/jira/browse/THRIFT-5143 for me. The required change is that the Thrift build for netstandard 2.0 can not be mixed and mingled with application builds for netstandard 2.0 or .net Framework, due to a missing dependency to reference assembly `System.Threading.Tasks.Extensions, Version=4.2.0.1`. This can be resolved by referencing the Thrift library artifact instead of the Thrift project file. See the Jira issue for a more detailed discussion. I've tested the build on Windows, macOS and Linux successfully. - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - Full cmake support is in a single commit. There are two other, minor changes to C# code in two other commits in this same PR. - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [x] If your change does not involve any code, add ` [skip ci]` at the end of your pull request to free up build resources. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
