ulidtko opened a new pull request #2124: URL: https://github.com/apache/thrift/pull/2124
Hi! Please see the [Jira issue][THRIFT-5186] for rationale. Basically, this patch enables Thrift clients & servers to continue working in "offline mode" — when only the loopback interace `lo` (127.0.0.1) is available, nothing more. With Thrift 0.13.0 on POSIX, C++ and Python clients/servers **crash with exception** in those conditions. This patch is used internally in our team, to compile a *vendored* version of Thrift. We'd like to contribute this patch upstream, to relieve ourselves from the maintenance burden of vendoring. Code review, comments, suggestions welcome! [THRIFT-5186]: https://issues.apache.org/jira/browse/THRIFT-5186 NB: no attempt was made to cover this patch with tests. Suggestions on how to simulate "no network" environment in the test suite would be highly appreciated. ------------------------------------------------------------------------------------------ - [x] Did you create an Apache Jira ticket? (not required for trivial changes) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
