xiaoqin-fu opened a new pull request #2178:
URL: https://github.com/apache/thrift/pull/2178
Adding LOGGER.isInfoEnabled() conditional statement into
org.apache.thrift.transport.thrift.transport.TTransport to fix the issue 4928
<!-- Explain the changes in the pull request below: -->
In org.apache.thrift.transport.TTransport in the previous approach,
sensitive information about expected and actual reading lengths (len, got) is
leaked. Thus, the LOGGER.isInfoEnabled()() conditional statements should be
added in the method readAll(byte[] buf, int off, int len).
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not
required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but
preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
