Github user sstach commented on the issue:
https://github.com/apache/thrift/pull/1014
Oh, have overseen that, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user nsuke commented on the issue:
https://github.com/apache/thrift/pull/1014
@sstach it's closed because it's merged to the master dd9885e
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sstach commented on the issue:
https://github.com/apache/thrift/pull/1014
@asfgit Why did you closed the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user kufd commented on the issue:
https://github.com/apache/thrift/pull/1014
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1014
Yes, continue to rebase against master and force push until it passes; if
there are no changes to pick up add an extra blank line to the end of one of
the files, commit, rebase/fixup and force push.
Github user kufd commented on the issue:
https://github.com/apache/thrift/pull/1014
I have merged changes from original thrift repo
But problems are still present
One travis job is failed because of timeout
AppVeyor is not finished yet
Should i merge changes again?
--
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1014
Please rebase your pull request against origin/master. The build may not
be 100% stabilized but we removed the offending Jenkins build that was
constantly failing. 2 out of my 3 open pull requests
Github user kufd commented on the issue:
https://github.com/apache/thrift/pull/1014
We use this fix in our prod and it works as mentioned.
But as i can see the build is failed not because of my changes
So i am just waiting for review from commiters.
---
If your project is
Github user sstach commented on the issue:
https://github.com/apache/thrift/pull/1014
Is there a chance that the build failures get fixed soon? We are facing the
same problem and this fix would be awesome if it works as mentioned!
---
If your project is set up for it, you can reply t
