[GitHub] thrift issue #1032: THRIFT-3476: fix missing header

2016-07-18 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1032 @jeking3 thanks, merging as failures cannot possibly be related (go and dart). Filed a [ticket](https://issues.apache.org/jira/browse/THRIFT-3883) for non-cross-test one. --- If your project is

[GitHub] thrift issue #1032: THRIFT-3476: fix missing header

2016-07-18 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1032 @jeking3 can you rebase this one too ? It seems quite safe and I could just test it on my travis account but it's always better to have history here. --- If your project is set up for it, you can rep

[GitHub] thrift issue #1032: THRIFT-3476: fix missing header

2016-07-11 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1032 Waiting for master to rev so I can rebase and kick this build again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] thrift issue #1032: THRIFT-3476: fix missing header

2016-06-22 Thread tpcwang
Github user tpcwang commented on the issue: https://github.com/apache/thrift/pull/1032 :+1: makes sense --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or