[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-10-04 Thread erikvanoosten
Github user erikvanoosten commented on the issue: https://github.com/apache/thrift/pull/1036 The specification documents are up at https://erikvanoosten.github.io/thrift-missing-specification/. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-09-21 Thread erikvanoosten
Github user erikvanoosten commented on the issue: https://github.com/apache/thrift/pull/1036 The feedback cycle took more then a month. This is too long for me. I do not have the mental capacity to keep work in my head for that long. Kind regards, Erik.

[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-09-21 Thread erikvanoosten
Github user erikvanoosten commented on the issue: https://github.com/apache/thrift/pull/1036 Feel free to take it. I won't support it anymore though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-09-20 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1036 Thanks for the reminder. Actually, I like it. Too bad it's closed now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-09-20 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1036 Why? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-09-20 Thread erikvanoosten
Github user erikvanoosten commented on the issue: https://github.com/apache/thrift/pull/1036 Closing this due to lack of interest of repo owners. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-08-17 Thread erikvanoosten
Github user erikvanoosten commented on the issue: https://github.com/apache/thrift/pull/1036 All, @Jens-G, this documentation is ready for another review. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-08-17 Thread erikvanoosten
Github user erikvanoosten commented on the issue: https://github.com/apache/thrift/pull/1036 Note: last commit is still work in progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-08-17 Thread erikvanoosten
Github user erikvanoosten commented on the issue: https://github.com/apache/thrift/pull/1036 @Jens-G wrote: > The Thrift compiler prevents the combination of oneway plus throws right from the start since March 2003, any types other than void are disallowed since THRIFT-2030. So th

[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-07-01 Thread erikvanoosten
Github user erikvanoosten commented on the issue: https://github.com/apache/thrift/pull/1036 Thanks @Jens-G . That's all useful feedback. Next week I have time to work on it further. Regarding structure: it took me weeks to collect all this information and create the document

[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-06-30 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1036 Overall pretty neat. I still have a few complaints. 1. The document repeats a lot of stuff that can be found elsewhere, e.g. in the Thrift Whitepaper. There is nothing per se wrong with repea