[GitHub] thrift issue #1096: fix snprintf error in TServerSocket.cpp under vs2013

2016-09-28 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1096 @CompileMaster see https://github.com/apache/thrift/pull/1099 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] thrift issue #1096: fix snprintf error in TServerSocket.cpp under vs2013

2016-09-28 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1096 Looks like I introduced the issue: https://github.com/apache/thrift/commit/e5176241c325837967a07d6d20e0e9a789fbd107 Fortunately it isn't in a release yet. --- If your project is s

[GitHub] thrift issue #1096: fix snprintf error in TServerSocket.cpp under vs2013

2016-09-28 Thread CompileMaster
Github user CompileMaster commented on the issue: https://github.com/apache/thrift/pull/1096 @jeking3 I'm glad you help me to submit a PR ,please do it, thanks a lot. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] thrift issue #1096: fix snprintf error in TServerSocket.cpp under vs2013

2016-09-27 Thread CompileMaster
Github user CompileMaster commented on the issue: https://github.com/apache/thrift/pull/1096 Second commit change "#if _MSC_VER" to "#if defined(_MSC_VER) && (_MSC_VER < 1900)" , compiliable with vs2015 --- If your project is set up for it, you can reply to this email and have yo

[GitHub] thrift issue #1096: fix snprintf error in TServerSocket.cpp under vs2013

2016-09-26 Thread CompileMaster
Github user CompileMaster commented on the issue: https://github.com/apache/thrift/pull/1096 @Jens-G windows+msvc has no "snprintf" funtion, but has "_snprintf" funtion. so should use "_snprintf" function replace the "snprintf" function. --- If your project is set up for it, you can

[GitHub] thrift issue #1096: fix snprintf error in TServerSocket.cpp under vs2013

2016-09-26 Thread CompileMaster
Github user CompileMaster commented on the issue: https://github.com/apache/thrift/pull/1096 Compiling under VS2013 error C3861: “snprintf”: Can't find the identifier , line 282, 527, 528 in TServerSocket.cpp --- If your project is set up for it, you can reply to this emai

[GitHub] thrift issue #1096: fix snprintf error in TServerSocket.cpp under vs2013

2016-09-26 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1096 Hi @CompileMaster, a bit more information about the problem would be nice. Aside from that, we have a nice [contribution guide](http://thrift.apache.org/docs/HowToContribute) that we would like you t