[GitHub] thrift issue #1119: Java generator: Added "java.lang." to all generated inst...

2016-10-31 Thread bgould
Github user bgould commented on the issue: https://github.com/apache/thrift/pull/1119 @jeking3 I agree completely. Didn't mean to give the impression that it shouldn't be supported. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] thrift issue #1119: Java generator: Added "java.lang." to all generated inst...

2016-10-31 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1119 @bgould Generated code should always be explicitly fully pathed or namespaced and never make any assumptions. Thrift already uses namespaces so I would have no problem with org.king.Object as a

[GitHub] thrift issue #1119: Java generator: Added "java.lang." to all generated inst...

2016-10-30 Thread bgould
Github user bgould commented on the issue: https://github.com/apache/thrift/pull/1119 @Jens-G IMO this is a valid use case but it is not necessarily a great idea because in general its not very user friendly to design an API that clashes names in java.lang.* ... it is even

[GitHub] thrift issue #1119: Java generator: Added "java.lang." to all generated inst...

2016-10-30 Thread ne0h
Github user ne0h commented on the issue: https://github.com/apache/thrift/pull/1119 Hi Jens-G, of course: https://issues.apache.org/jira/browse/THRIFT-3954 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift issue #1119: Java generator: Added "java.lang." to all generated inst...

2016-10-30 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1119 Hi @ne0h, could you just [create a JIRA ticket for this](http://thrift.apache.org/docs/HowToContribute)? @Java devs: Comments anyone? --- If your project is set up for it, you