[GitHub] thrift issue #1128: THRIFT-3873: fix compiler warnings on windows with VS201...

2017-01-11 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1128 There was just one issue on linux; I reverted a change in TBufferTransports.h (I had converted an assert to an exception, but we can figure out what to do with asserts holistically in THRIFT-3978).

[GitHub] thrift issue #1128: THRIFT-3873: fix compiler warnings on windows with VS201...

2017-01-10 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1128 Hi, I pushed fixes for the open issues however I need to make sure it still builds on linux; my local build failed so it looks like there will be another push to clean that up. Thanks for your

[GitHub] thrift issue #1128: THRIFT-3873: fix compiler warnings on windows with VS201...

2016-11-14 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1128 @ben-craig Thanks these are great comments, I will make some changes to improve this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as