[GitHub] thrift issue #1186: THRIFT-1805 Provide option for handling RTEs

2017-07-03 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/thrift/pull/1186 @Jens-G I will look and comment on THRIFT-4239. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] thrift issue #1186: THRIFT-1805 Provide option for handling RTEs

2017-07-01 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1186 @ctubbsii: Could you please have a look at [THRIFT-4239](https://issues.apache.org/jira/browse/THRIFT-4239)? Not sure if it has sth. to do with your patch, but it came up while looking for the cause,

[GitHub] thrift issue #1186: THRIFT-1805 Provide option for handling RTEs

2017-02-22 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1186 My guess is there would be fairly easy ways to unit test this behavior so it doesn't need to be an integration test. Also, +1 for using the term Mocket. Love that. --- If your project is set up

[GitHub] thrift issue #1186: THRIFT-1805 Provide option for handling RTEs

2017-02-09 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/thrift/pull/1186 I'm not familiar enough with Thrift's testing framework to add tests, but this works tested locally. I don't know if this makes sense for other languages, but it seems to make a lot of sense fo