Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1196
Could someone please do a code review and approve or request changes?
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1196
Once someone has a chance to approve the changes I can merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1196
@nsuke this is ready for review again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1196
@nsuke to test this I ran TNonblockingServerTest in a tight loop for 30
minutes. It never made it past 30 seconds before, and that was with 300ms
delay built into each test. The test runs much fas
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1196
In the next push I have changed the way the nonblocking server test starts
up, avoiding a ~100ms delay three times. Then I changed how the loop stops so
that it always stops from inside using loopb
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1196
The failure looks like an inability to stop the loop.
I an going to look into changing the nonblocking server's stop() method to
inject an event that causes it to call loopbreak from within the l
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1196
Looks like I ran the build and tests outside the dockerfile so it didn't do
any libevent stuff. :|
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
