[GitHub] thrift issue #1214: THRIFT-2026: Eliminate some undefined behavior in C/C++

2017-03-25 Thread jbapple-cloudera
Github user jbapple-cloudera commented on the issue: https://github.com/apache/thrift/pull/1214 OK, this new patch does not change the definitions of any `enum`s, only their usages. It also adds undefined behavior checking to the pre-merge CI tests on Travis to discourage

[GitHub] thrift issue #1214: THRIFT-2026: Eliminate some undefined behavior in C/C++

2017-03-22 Thread jbapple-cloudera
Github user jbapple-cloudera commented on the issue: https://github.com/apache/thrift/pull/1214 Agreed. I'l get to that as soon as I have a chance and then I'll ping this PR for review when it has addressed that. --- If your project is set up for it, you can reply to this email and

[GitHub] thrift issue #1214: THRIFT-2026: Eliminate some undefined behavior in C/C++

2017-03-20 Thread jbapple-cloudera
Github user jbapple-cloudera commented on the issue: https://github.com/apache/thrift/pull/1214 Can this be on hold for a bit? I would like to add the UBSan checks to .travis.yml first, which may take a couple of days for me to have time for. --- If your project is set up for it,