[GitHub] thrift issue #1222: THRIFT-4134-Fix-remaining-undefined-behavior-invalid.pat...

2017-03-26 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1222 To be honest, my intention is to fix the actual problem, not to refactor the whole app. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] thrift issue #1222: THRIFT-4134-Fix-remaining-undefined-behavior-invalid.pat...

2017-03-26 Thread jbapple-cloudera
Github user jbapple-cloudera commented on the issue: https://github.com/apache/thrift/pull/1222 How about ``` void t_json_generator::write_type_spec(t_type* ttype) { ttype = ttype->get_true_type(); write_string(get_type_name(ttype)); if

[GitHub] thrift issue #1222: THRIFT-4134-Fix-remaining-undefined-behavior-invalid.pat...

2017-03-26 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1222 No, the intention is to patch everything. A few things are still open, but I will update the PR until we have it all. --- If your project is set up for it, you can reply to this email and have your

[GitHub] thrift issue #1222: THRIFT-4134-Fix-remaining-undefined-behavior-invalid.pat...

2017-03-26 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1222 ``` void t_json_generator::write_type_spec(t_type* ttype) { ttype = ttype->get_true_type(); write_string(get_type_name(ttype)); if (ttype->is_struct() ||