[GitHub] thrift issue #1285: THRIFT-4215/4216 Make transport factories return errors

2017-06-02 Thread dcelasun
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1285 Closing PR until all tests are fixed, I don't want to waste Apache's Travis capacity. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] thrift issue #1285: THRIFT-4215/4216 Make transport factories return errors

2017-06-06 Thread peterbourgon
Github user peterbourgon commented on the issue: https://github.com/apache/thrift/pull/1285 For the record, this caused build failures in Go kit; I don't imagine my usage is particularly strange, but maybe it is. ([Link](https://github.com/go-kit/kit/commit/4d3c82de4829f7c3752cf66d00d

[GitHub] thrift issue #1285: THRIFT-4215/4216 Make transport factories return errors

2017-06-06 Thread dcelasun
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1285 Yes sorry about that, this was an expected breakage as the interface has changed. I suggest using `0.10` instead of `master`, that way you won't get any surprises like this until `0.11` is released