Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1311
@davinchia we've cleared out the CI build issues, so if you could squash
your changes to one commit then rebase on master, then do a force push to
refresh this pull request, it'll kick off a new
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1311
@davinchia we've cleared out the CI build issues, so if you could squash
your changes to one commit then rebase on master, then do a force push to
refresh this pull request, it'll kick off a new
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1311
@davinchia we've cleared out the CI build issues, so if you could squash
your changes to one commit then rebase on master, then do a force push to
refresh this pull request, it'll kick off a new
Github user davinchia commented on the issue:
https://github.com/apache/thrift/pull/1311
@Jens-G Github must have hidden my comments. My latest commit combined the
functions and removed the toString function as per your suggestions.
Not sure why one of the integration tests
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1311
Ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user davinchia commented on the issue:
https://github.com/apache/thrift/pull/1311
@Jens-G
This is the first time I'm writing production C++ code so please feel free
to tear this apart.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user davinchia commented on the issue:
https://github.com/apache/thrift/pull/1311
https://stackoverflow.com/questions/30716354/how-do-i-do-a-literal-int64-in-go
is a good summary of the different ways to assign constant values in Go.
I decided to use an anonymous
