[GitHub] thrift issue #1312: THRIFT-4260: Add context as first arg for client method.

2017-09-12 Thread taozle
Github user taozle commented on the issue: https://github.com/apache/thrift/pull/1312 You must use the generator compiled from the master branch. ---

[GitHub] thrift issue #1312: THRIFT-4260: Add context as first arg for client method.

2017-09-12 Thread domino14
Github user domino14 commented on the issue: https://github.com/apache/thrift/pull/1312 Is this in the latest version of thrift? It seems that auto-generated code does not have `context` in its function signatures, but thrift itself requires them, so auto-generated code does not compi

[GitHub] thrift issue #1312: THRIFT-4260: Add context as first arg for client method.

2017-07-24 Thread dcelasun
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1312 LGTM (once again, travis failure is unrelated) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea