Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1336
I opened THRIFT-4325 for this.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1336
I like the changes as proposed; this needs an Apache Jira ticket stating
the problem and resolution in order to get merged.
https://thrift.apache.org/docs/HowToContribute
Thanks!
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1336
Thanks, it was late when I posted the comment and I misread the change! If
there's any way you could rebase on master, squash, and force push that will
kick off another CI build to validate the fix
Github user tpetazzoni commented on the issue:
https://github.com/apache/thrift/pull/1336
Well, my patch precisely removes the override in every Makefile.am, so I'm
not sure to understand your question.
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1336
Wouldn't we want the value in configure.ac to percolate through? Why
override it in every Makefile.am?
---
