[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.

2017-09-07 Thread walter-weinmann
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1346 @jeking3 please have a look at THRIFT-2289 and THRIFT-2889 - I suppose both can be closed. ---

[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.

2017-09-07 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1346 Building Appveyor right now probably not, since I don't think we do erlang on windows in our CI right now. In order to get there, we need erlang support in the cmake build environment. The travis

[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.

2017-09-07 Thread walter-weinmann
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1346 The `erlang:timestamp/0` method seems to be a very old kernel methods - from the [release notes](http://erlang.org/doc/apps/kernel/notes.html) (current kernel release is 5.3): > 1.4

[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.

2017-09-07 Thread walter-weinmann
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1346 The problems were with Travis with varying reasons. I think it would be interesting to look into it. There may be a couple of pull request with bad results in Travis based on Travis internal

[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.

2017-09-07 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1346 What versions of Erlang would this change eliminate as usable with Thrift? I am finding it hard to locate the erlang release where the timestamp method was introduced. ---

[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.

2017-09-07 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1346 @walter-weinmann what was failing - Appveyor or Travis? There are some known build issues lurking about. I just eliminated one that popped up occasionally with concurrency_test in C++, however I j

[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.

2017-09-07 Thread walter-weinmann
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1346 The checks are really tedious - I needed 5 attempts until everything had gone through without any problems. ---

[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.

2017-09-07 Thread walter-weinmann
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1346 Restarting the checks. ---

[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.

2017-09-07 Thread walter-weinmann
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1346 Restarting the checks. ---

[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.

2017-09-07 Thread walter-weinmann
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1346 Restarting the checks. ---

[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.

2017-09-07 Thread walter-weinmann
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1346 Restarting the checks. ---

[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.

2017-09-06 Thread walter-weinmann
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1346 Restart checks. ---

[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.

2017-09-06 Thread walter-weinmann
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1346 This closes #1346 ---