Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1360
@sadikovi Sorry for the delay - was away this weekend.
Ah, ok. That makes total sense. You probably don't have any floats in your
IDL, or anything that would use the `TryFrom`
Github user sadikovi commented on the issue:
https://github.com/apache/thrift/pull/1360
@Jens-G could you review this PR, please? Thanks!
---
Github user sadikovi commented on the issue:
https://github.com/apache/thrift/pull/1360
@allengeorge When I compile parquet-rs library I get following warnings
([parquet.thrift](https://github.com/sadikovi/parquet-rs/blob/master/src/parquet_thrift/parquet.thrift))
```shell
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1360
@sadikovi The change seems fine, but I don't quite understand when this
problem happens. Could you explain when it gets triggered? In what sort of code
setup? Thanks!
---
Github user mrwiggles commented on the issue:
https://github.com/apache/thrift/pull/1360
@sadikovi The change seems fine, but I don't understand when this warning
gets triggered. Could you explain a bit more what you mean? When does this
happen, and why? Thanks!
---
Github user sadikovi commented on the issue:
https://github.com/apache/thrift/pull/1360
CI failures do not seem to be related.
---
Github user sadikovi commented on the issue:
https://github.com/apache/thrift/pull/1360
@allengeorge could you have a look at this change? Thanks!
---
