[GitHub] thrift issue #1367: Fix a crash on client close

2017-09-22 Thread djnym
Github user djnym commented on the issue: https://github.com/apache/thrift/pull/1367 I added a jira ticket yesterday https://issues.apache.org/jira/browse/THRIFT-4339 ---

[GitHub] thrift issue #1367: Fix a crash on client close

2017-09-22 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1367 I opened THRIFT-4340 for you on this. ---

[GitHub] thrift issue #1367: Fix a crash on client close

2017-09-21 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1367 @dhull thank you! Now we just need a Jira item for the change, and hopefully it sails through CI. ---

[GitHub] thrift issue #1367: Fix a crash on client close

2017-09-21 Thread dhull
Github user dhull commented on the issue: https://github.com/apache/thrift/pull/1367 This fix looks correct to me. The `read` and `read_exact` functions both pull the wrapped transport out of their state, and need to put the updated wrapped transport back into their state on return.

[GitHub] thrift issue #1367: Fix a crash on client close

2017-09-21 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1367 Thanks for the fix - changes need a Jira ticket so we can track them through release notes. See: https://thrift.apache.org/docs/HowToContribute Thanks! ---