Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1411
@jeking3 LGTM
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1411
@dcelasun can you approve if these changes look good to you?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1411
Thanks - once the CI builds pass I will re-review.
---
Github user trotterdylan commented on the issue:
https://github.com/apache/thrift/pull/1411
Done. Updated the commit message accordingly.
---
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1411
Please revert the `NewTHttpClient` part of this PR, since `THttpPostClient`
is deprecated and is just an alias for `THttpClient` since 0dd82358.
---
Github user trotterdylan commented on the issue:
https://github.com/apache/thrift/pull/1411
Done! https://issues.apache.org/jira/browse/THRIFT-4385
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1411
He @trotterdylan please review
https://thrift.apache.org/docs/HowToContribute as we need a Jira ticket for
this change.
---
