[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...

2018-01-12 Thread allengeorge
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1458 @jeking3 Looks like everything passed, so this patch is good to go. TY! ---

[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...

2018-01-11 Thread allengeorge
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1458 @jeking3 Thank you! So...updated the PR to re-add the three failing tests. Created [THRIFT-4451](https://issues.apache.org/jira/browse/THRIFT-4451) to track this. I'm going to fix up

[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...

2018-01-10 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1458 Sure - I like progress. :) ---

[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...

2018-01-09 Thread allengeorge
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1458 @jeking3 This seems like a separate problem unfortunately. I'd removed three tests from the "known failures list" and it appears there's a specific problem related to multiplexed processors and

[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...

2018-01-07 Thread allengeorge
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1458 @jeking3 This seems like a separate problem unfortunately. I'd removed three tests from the "known failures list" and it appears there's a specific problem related to multiplexed processors and

[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...

2018-01-05 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1458 There were related cross test errors: ``` === *** Following 3 failures were unexpected ***: If it is

[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...

2018-01-05 Thread allengeorge
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1458 One of two fixes for problems noticed by others during cross-tests. I've a separate PR for framed transports. ---