Github user jfarrell commented on the issue:
https://github.com/apache/thrift/pull/1474
Hi @yfeldblum, thanks for taking a look into this for us, appreciate your
help. A new PR would be great that way it gives the ASF the needed audit trail
of the origination of the pull request code
Github user yfeldblum commented on the issue:
https://github.com/apache/thrift/pull/1474
@jfarrell Does Apache actually need a new PR originating from FB? Or is it
sufficient for FB to okay this PR?
---
Github user jfarrell commented on the issue:
https://github.com/apache/thrift/pull/1474
We can not directly accept this PR as it contains code that originated in
fbthrift. We need someone from Facebook to contribute the code or files back to
Apache Thrift for use by the ASF.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1474
@jfarrell can you please give a final say on this?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1474
@jfarrell can you please give a final say on this?
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1474
Based on my read of the file from which the original source information
came, the original fbthrift project files are Apache Source licensed. So I'm
not certain we need to do anything in
Github user jparise commented on the issue:
https://github.com/apache/thrift/pull/1474
Coming back to the original proposed change, is this likely or unlikely to
be merged?
I don't think I fully understand @jfarrell's "this change must originate
from Facebook" requirement.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1474
@jfarrell from what I can see these error codes are inside contributed code
in the fbthrift project, at least from the C++ side, in a file that contains
the Apache license:
Github user jfarrell commented on the issue:
https://github.com/apache/thrift/pull/1474
@jeking3 `Do we really need to ask for permission to add three additional
error codes from fbthrift?` - yes, if there is something in Facebook fbthrift
that someone wants to add to Apache Thrift
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1474
Not sure.
We had that discussion in the past IIRC and the outcome was that we leave
it as it is. It's somewhere buried in the archives, maybe we heven had (or
still have) a ticket for it.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1474
@Jens-G what do you think about the notion of moving the definition of
error message enumerations into a single common .thrift file that gets compiled
and then comsumed by the libraries? It would
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1474
In general I frown upon adding test-only values in production code (like
"injected failure"). That said I see no reason for us not to incorporate these
into the core. Do we really need to ask for
Github user jparise commented on the issue:
https://github.com/apache/thrift/pull/1474
I'm not affiliated with either project, but I work in an environment that
uses multiple Thrift implementations, so interoperability is important to us.
We're specifically interested in using some
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1474
I see the point but I'm not sure if Inunderstzand it right. Who doies what
before we add new codes? We ask FB? Or they ask us? And what ist your plan to
convince FB that they have to ask us?
---
14 matches
Mail list logo
