Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1502
In the future you can squash, rebase, and force push to keep the same PR,
see:
https://thrift.apache.org/docs/HowToContribute
---
Github user bananer commented on the issue:
https://github.com/apache/thrift/pull/1502
Rebased as https://github.com/apache/thrift/pull/1506
---
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1502
Okay that sounds good; could you squash and rebase on master to prepare for
a merge?
---
Github user bananer commented on the issue:
https://github.com/apache/thrift/pull/1502
The package-lock file keeps dependency versions fixed across all
installations. According to [the
docs](https://docs.npmjs.com/files/package-lock.json), this does not apply when
the package is publ
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1502
Any special considerations we need to add to the README for js or nodejs if
we check in a package-lock.json file? When distributing through npm should
this file also be distributed?
---
