[GitHub] thrift issue #1516: THRIFT-4527 Upgrade byteorder in rust

2018-03-23 Thread allengeorge
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1516 OK. Looks like the build failures are unrelated. I'm going to apply locally and check cross-tests just to make sure, but will get this applied today. Thank you @QuestofIranon! Always happy to

[GitHub] thrift issue #1516: THRIFT-4527 Upgrade byteorder in rust

2018-03-22 Thread QuestofIranon
Github user QuestofIranon commented on the issue: https://github.com/apache/thrift/pull/1516 @allengeorge It creates dependency conflicts with other libraries that rely on the updated version of byteorder. For example, I couldn't build a project using Thrift because my other

[GitHub] thrift issue #1516: THRIFT-4527 Upgrade byteorder in rust

2018-03-21 Thread allengeorge
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1516 LGTM. @QuestofIranon just curious - why bump the version? ---