Github user eevee commented on the pull request:
https://github.com/apache/thrift/pull/156#issuecomment-52856812
i'm confused as to how this works at all; thrift doesn't support python 3
atm, and even in 3.2+, there's no builtin named PYTHONHASHSEED.
why is this manually
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/156#issuecomment-52234520
@Dustin Spicuzza,
PYTHONHASHSEED breaks clients using Python 3.2
is there a way to define PYTHONHASHSEED for older versions as a simple
constant? I'd
Github user virtuald commented on the pull request:
https://github.com/apache/thrift/pull/156#issuecomment-52236059
You could add something at the top of the file? if sys.version[0] 3
PYTHONHASHSEED = 42... not sure what the best way to deal with this otherwise
would be.
---
If
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/156#issuecomment-52238173
Yeah, something like this. Right now I can't do it myself, sorry. If you
want to provide a patch or pull request, someone will take care of it, just
mention the number of
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/156#issuecomment-50931303
I forgot to reference the pull request in the commit.
Could you please close it manually? Thanks!
---
If your project is set up for it, you can reply to this email
Github user kishorvpatil commented on the pull request:
https://github.com/apache/thrift/pull/156#issuecomment-50939441
Thanks you @Jens-G. Closing the request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kishorvpatil closed the pull request at:
https://github.com/apache/thrift/pull/156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kishorvpatil commented on the pull request:
https://github.com/apache/thrift/pull/156#issuecomment-48945607
Please let me know your comments on improved improved thrift function.
Thank you again for taking time to review the changes.
---
If your project is set up for it,
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/thrift/pull/155
Add basic default hash code method to python, doesn't work for maps/lists
This based off Nathan Matz's patch for storm branch
6d4b008512cd9fcd5a6bb598d09f35eaf2dc7412
You can merge this pull
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/155#issuecomment-48658641
-1
Something's wrong with your proposed changes. You really want to change the
version of the current Thrift trunk from 1.0.0 back to 0.9.1 which was released
Github user kishorvpatil commented on the pull request:
https://github.com/apache/thrift/pull/155#issuecomment-48666313
sorry about that. I will close this one and raise another.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user kishorvpatil closed the pull request at:
https://github.com/apache/thrift/pull/155
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/thrift/pull/156
Add basic default hash code method to python,
It doesn't work for maps/lists. This based off Nathan Matz's patch for
storm branch 6d4b008512cd9fcd5a6bb598d09f35eaf2dc7412
You can
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/156#issuecomment-48669749
Tracked in THRIFT-2621
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
14 matches
Mail list logo
